fix(playwright): drop obsolete useGoogleSheetAsDefault toggle in (c)#1475
Merged
renemadsen merged 1 commit intostablefrom Apr 15, 2026
Merged
fix(playwright): drop obsolete useGoogleSheetAsDefault toggle in (c)#1475renemadsen merged 1 commit intostablefrom
renemadsen merged 1 commit intostablefrom
Conversation
The ensure-on block for #useGoogleSheetAsDefault hung the (c) suite for the full 120s timeout. Two business-logic changes made it unreachable: - e86d3a1 seeds useGoogleSheetAsDefault=true for every assigned site on install, so no flip is needed. - c7732b4 gates the checkbox behind selectCurrentUserIsFirstUser$ in assigned-site-dialog.component.html:9, so the element never renders for the admin CI user. The subsequent autoBreakCalculationActive block is admin-gated and still valid, so the test's actual intent ("should enable auto break calculations with empty values") survives. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#useGoogleSheetAsDefaultinc/dashboard-edit-a.spec.ts— it hung the suite for 120s because the checkbox is now (a) seeded true by default (e86d3a1) and (b) gated behindselectCurrentUserIsFirstUser$(c7732b4), so it never renders for the admin CI user.autoBreakCalculationActiveblock is preserved — that's the assertion the test actually cares about.Test plan
pn-playwright-test (c)goes green on this PR(a),(b), and the other groups remain green🤖 Generated with Claude Code